Fix EditorPlugin.remove_inspector_plugin() instance cleanup
#55658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
added
bug
topic:editor
topic:plugin
cherrypick:3.x
lawnjelly
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Looks good. 👍
I was unsure about the method of not explicitly deleting but it seems okay it should be handled by refcounts. Overwriting element idx should send refcount to 0 and delete it, and set refcount to 2 for the one that overwrites, then one in turn as that is overwritten. The exception is the last element which remains at 2, and needs the explicit setting to NULL which sets the last but one ref count to 1 (from 2).
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55648
godot/editor/editor_inspector.cpp
Lines 2194 to 2202 in b8ebe3b
It's safe only if you remove inspector plugins in a LIFO fashion.
Since all elements after
idxare moved forward by one, we should always unreference the last element in use.